Version 0.0.9

configure.ac

@@ -1,5 +1,5 @@
 AC_PREREQ([2.65])
-AC_INIT([glorytun], [0.0.7], [https://github.com/angt/glorytun/issues],
+AC_INIT([glorytun], [0.0.9], [https://github.com/angt/glorytun/issues],
         [glorytun], [https://github.com/angt/glorytun])
 AC_CONFIG_SRCDIR([src/common.h])
 AC_CONFIG_AUX_DIR([build-aux])

src/common.h

@@ -14,9 +14,13 @@
 #define PALIGN(x)      ((void *)ALIGN((size_t)(x)))
 #define PALIGN_DOWN(x) ((void *)ALIGN_DOWN((size_t)(x)))
 
+#define _1_(x)         (__builtin_expect((x), 1))
+#define _0_(x)         (__builtin_expect((x), 0))
+
 #define _printf_(A,B)  __attribute__((format(printf,A,B)))
 #define _noreturn_     __attribute__((noreturn))
 #define _unused_       __attribute__((unused))
+#define _align_(...)   __attribute__((aligned(__VA_ARGS__)))
 
 typedef struct buffer buffer_t;
 

src/main.c

@@ -35,9 +35,8 @@ struct fdbuf {
 };
 
 struct blk {
-    uint8_t prio;
     size_t size;
-    uint8_t data[GT_MTU_MAX];
+    uint8_t data[GT_MTU_MAX] _align_(16);
 };
 
 struct crypto_ctx {
@@ -49,6 +48,7 @@ struct crypto_ctx {
 };
 
 volatile sig_atomic_t gt_close = 0;
+volatile sig_atomic_t gt_info = 0;
 
 static int64_t dt_ms (struct timeval *ta, struct timeval *tb)
 {
@@ -84,6 +84,7 @@ enum sk_opt {
     sk_keepintvl,
     sk_congestion,
     sk_defer_accept,
+    sk_quickack,
 };
 
 static void sk_set (int fd, enum sk_opt opt, const void *val, socklen_t len)
@@ -123,6 +124,11 @@ static void sk_set (int fd, enum sk_opt opt, const void *val, socklen_t len)
         [sk_defer_accept] = { "TCP_DEFER_ACCEPT",
 #ifdef TCP_DEFER_ACCEPT
             1, IPPROTO_TCP, TCP_DEFER_ACCEPT,
+#endif
+        },
+        [sk_quickack] = { "TCP_QUICKACK",
+#ifdef TCP_QUICKACK
+            1, IPPROTO_TCP, TCP_QUICKACK,
 #endif
         },
     };
@@ -314,20 +320,29 @@ static void gt_sa_stop (int sig)
 {
     switch (sig) {
     case SIGINT:
+    case SIGQUIT:
     case SIGTERM:
         gt_close = 1;
+        break;
+    case SIGUSR1:
+        gt_info = 1;
+        break;
     }
 }
 
 static void gt_set_signal (void)
 {
-    struct sigaction sa;
+    struct sigaction sa = {
+        .sa_flags = 0,
+    };
 
-    byte_set(&sa, 0, sizeof(sa));
+    sigemptyset(&sa.sa_mask);
 
     sa.sa_handler = gt_sa_stop;
     sigaction(SIGINT,  &sa, NULL);
+    sigaction(SIGQUIT, &sa, NULL);
     sigaction(SIGTERM, &sa, NULL);
+    sigaction(SIGUSR1, &sa, NULL);
 
     sa.sa_handler = SIG_IGN;
     sigaction(SIGHUP,  &sa, NULL);
@@ -337,7 +352,7 @@ static void gt_set_signal (void)
 static ssize_t fd_read (int fd, void *data, size_t size)
 {
     if (!size)
-        return -2;
+        return -1;
 
     ssize_t ret = read(fd, data, size);
 
@@ -357,7 +372,7 @@ static ssize_t fd_read (int fd, void *data, size_t size)
 static ssize_t fd_write (int fd, const void *data, size_t size)
 {
     if (!size)
-        return -2;
+        return -1;
 
     ssize_t ret = write(fd, data, size);
 
@@ -638,15 +653,6 @@ int main (int argc, char **argv)
     long ka_count = -1;
     long ka_idle = -1;
     long ka_interval = -1;
-    long prio_dscp = 46;
-    long prio_size = (GT_TUNR_SIZE*3)/4;
-
-#ifdef TCP_INFO
-    struct {
-        struct timeval time;
-        struct tcp_info info;
-    } tcpinfo = {0};
-#endif
 
     struct option ka_opts[] = {
         { "count",    &ka_count,    option_long },
@@ -655,12 +661,6 @@ int main (int argc, char **argv)
         { NULL },
     };
 
-    struct option prio_opts[] = {
-        { "dscp",  &prio_dscp, option_long },
-        { "size",  &prio_size, option_long },
-        { NULL },
-    };
-
     struct option opts[] = {
         { "listener",    NULL,         option_option },
         { "host",        &host,        option_str    },
@@ -672,9 +672,8 @@ int main (int argc, char **argv)
         { "multiqueue",  NULL,         option_option },
         { "keepalive",   ka_opts,      option_option },
         { "buffer-size", &buffer_size, option_long   },
-        { "priority",    prio_opts,    option_option },
+        { "noquickack",  NULL,         option_option },
         { "daemon",      NULL,         option_option },
-        { "debug",       NULL,         option_option },
         { "version",     NULL,         option_option },
         { NULL },
     };
@@ -689,24 +688,14 @@ int main (int argc, char **argv)
 
     int listener = option_is_set(opts, "listener");
     int delay = option_is_set(opts, "delay");
-    int debug = option_is_set(opts, "debug");
     int keepalive = option_is_set(opts, "keepalive");
+    int noquickack = option_is_set(opts, "noquickack");
 
     if (buffer_size < 2048) {
         buffer_size = 2048;
         gt_log("buffer size must be greater than 2048!\n");
     }
 
-    if (prio_size < 0) {
-        prio_size = 0;
-        gt_log("priority size must be positive!\n");
-    }
-
-    if (prio_size > GT_TUNR_SIZE) {
-        prio_size = GT_TUNR_SIZE;
-        gt_log("priority size must be less than or equal to %zu\n", GT_TUNR_SIZE);
-    }
-
     if (sodium_init()==-1) {
         gt_log("libsodium initialization has failed!\n");
         return 1;
@@ -737,7 +726,6 @@ int main (int argc, char **argv)
 
     struct blk *blks = calloc(256, sizeof(struct blk));
     size_t blk_count = 0;
-    size_t blk_prio = 0;
     uint8_t blk_read = 0;
     uint8_t blk_write = 0;
 
@@ -840,12 +828,6 @@ int main (int argc, char **argv)
 
             FD_SET(sock.fd, &rfds);
 
-            if (buffer_read_size(&tun.read) || blk_count)
-                FD_SET(sock.fd, &wfds);
-
-            if (buffer_read_size(&sock.read))
-                FD_SET(tun.fd, &wfds);
-
             if (select(sock.fd+1, &rfds, &wfds, NULL, NULL)==-1) {
                 if (errno==EINTR)
                     continue;
@@ -856,14 +838,18 @@ int main (int argc, char **argv)
             FD_CLR(sock.fd, &wfds);
             FD_CLR(tun.fd, &wfds);
 
-#ifdef TCP_INFO
+         // TODO
-            struct timeval now;
+         // struct timeval now;
-            gettimeofday(&now, NULL);
+         // gettimeofday(&now, NULL);
 
-            if (debug && dt_ms(&now, &tcpinfo.time)>1000LL) {
+#ifdef TCP_INFO
-                tcpinfo.time = now;
+            if (gt_info) {
-                if (sk_get_info(sock.fd, &tcpinfo.info))
+                struct tcp_info ti;
-                    print_tcp_info(sockname, &tcpinfo.info);
+
+                if (sk_get_info(sock.fd, &ti))
+                    print_tcp_info(sockname, &ti);
+
+                gt_info = 0;
             }
 #endif
 
@@ -872,11 +858,10 @@ int main (int argc, char **argv)
                     uint8_t *data = blks[blk_write].data;
                     ssize_t r = tun_read(tun.fd, data, GT_MTU_MAX);
 
-                    if (!r)
+                    if (r<=0) {
-                        return 2;
+                        gt_close |= !r;
-
-                    if (r<0)
                         break;
+                    }
 
                     ssize_t ip_size = ip_get_size(data, GT_MTU_MAX);
 
@@ -893,83 +878,55 @@ int main (int argc, char **argv)
                         }
                     }
 
-                    if (ip_get_dscp(data, GT_MTU_MAX)==prio_dscp) {
-                        blks[blk_write].prio = 1;
-                        blk_prio++;
-                    } else {
-                        blks[blk_write].prio = 0;
-                    }
-
                     blks[blk_write++].size = r;
                     blk_count++;
                 }
             }
 
-            buffer_shift(&tun.read);
+            while (1) {
+                buffer_shift(&tun.read);
 
-            // XXX prio code needs a full rewrite :)
+                if (!stop_loop) {
+                    for (; blk_count; blk_read++) {
+                        if (!blks[blk_read].size)
+                            break;
 
-            if (blk_prio) {
+                        if (buffer_write_size(&tun.read)<blks[blk_read].size)
-                uint8_t k = blk_read;
+                            break;
 
-                while (blk_prio && buffer_read_size(&tun.read)<(size_t)prio_size) {
+                        byte_cpy(tun.read.write, blks[blk_read].data, blks[blk_read].size);
-                    while (!blks[k].prio || !blks[k].size)
+                        tun.read.write += blks[blk_read].size;
-                        k++;
 
-                    if (buffer_write_size(&tun.read)<blks[k].size)
+                        blks[blk_read].size = 0;
-                        break;
+                        blk_count--;
+                    }
 
-                    byte_cpy(tun.read.write, blks[k].data, blks[k].size);
+                    gt_encrypt(&ctx, &sock.write, &tun.read);
-                    tun.read.write += blks[k].size;
-
-                    blks[k].size = 0;
-                    blk_count--;
-                    blk_prio--;
-
-                    if (blk_read==k)
-                        blk_read++;
-
-                    k++;
-                }
-            }
-
-            while (blk_count) {
-                if (!blks[blk_read].size) {
-                    blk_read++;
-                    continue;
                 }
 
-                if (buffer_write_size(&tun.read)<blks[blk_read].size)
+                if (!buffer_read_size(&sock.write))
                     break;
 
-                byte_cpy(tun.read.write, blks[blk_read].data, blks[blk_read].size);
-                tun.read.write += blks[blk_read].size;
-
-                if (blks[blk_read].prio)
-                    blk_prio--;
-
-                blks[blk_read++].size = 0;
-                blk_count--;
-            }
-
-            gt_encrypt(&ctx, &sock.write, &tun.read);
-
-            if (buffer_read_size(&sock.write)) {
                 ssize_t r = fd_write(sock.fd, sock.write.read,
                                      buffer_read_size(&sock.write));
 
-                if (r==-1)
+                if (r>0) {
-                    FD_SET(sock.fd, &wfds);
-
-                if (!r)
-                    stop_loop |= (1<<2);
-
-                if (r>0)
                     sock.write.read += r;
-            } else {
+                } else {
-                if (stop_loop) {
+                    if (!r) {
-                    gt_log("%s: shutdown\n", sockname);
+                        stop_loop |= (1<<2);
+                    } else {
+                        FD_SET(sock.fd, &wfds);
+                    }
+                    break;
+                }
+            }
+
+            if (stop_loop && !buffer_read_size(&sock.write)) {
+                if (!(stop_loop&(1<<2))) {
+                    stop_loop |= (1<<2);
                     shutdown(sock.fd, SHUT_WR);
+                    gt_log("%s: shutdown\n", sockname);
                 }
             }
 
@@ -977,14 +934,17 @@ int main (int argc, char **argv)
             buffer_shift(&sock.read);
 
             if (FD_ISSET(sock.fd, &rfds)) {
+                if (noquickack)
+                    sk_set_int(sock.fd, sk_quickack, 0);
+
                 ssize_t r = fd_read(sock.fd, sock.read.write,
                                     buffer_write_size(&sock.read));
 
-                if (!r)
+                if (r>0) {
-                    stop_loop |= (1<<1);
-
-                if (r>0)
                     sock.read.write += r;
+                } else if (!r) {
+                    stop_loop |= (1<<1);
+                }
             }
 
             while (1) {
@@ -1006,14 +966,13 @@ int main (int argc, char **argv)
 
                 ssize_t r = tun_write(tun.fd, tun.write.read, ip_size);
 
-                if (!r)
+                if (r>0) {
-                    return 2;
-
-                if (r==-1)
-                    FD_SET(tun.fd, &wfds);
-
-                if (r>0)
                     tun.write.read += r;
+                } else {
+                    gt_close |= !r;
+                    FD_SET(tun.fd, &wfds);
+                    break;
+                }
             }
 
             buffer_shift(&tun.write);

src/tun.c

@@ -124,7 +124,7 @@ int tun_create (_unused_ char *name, _unused_ int mq)
 ssize_t tun_read (int fd, void *data, size_t size)
 {
     if (!size)
-        return -2;
+        return -1;
 
 #ifdef GT_BSD_TUN
     uint32_t family;
@@ -162,7 +162,7 @@ ssize_t tun_read (int fd, void *data, size_t size)
 ssize_t tun_write (int fd, const void *data, size_t size)
 {
     if (!size)
-        return -2;
+        return -1;
 
 #ifdef GT_BSD_TUN
     uint32_t family;