Update mud

This allows to build easily with other libc.

Makefile.am

@@ -7,7 +7,6 @@ glorytun_LDADD = $(libsodium_LIBS)
 glorytun_SOURCES = \
     src/common.h \
     src/common.c \
-    src/buffer.h \
     src/ip.h \
     src/str.h \
     src/main.c \
@@ -16,9 +15,7 @@ glorytun_SOURCES = \
     src/tun.c \
     src/tun.h \
     src/db.c \
-    src/db.h \
+    src/db.h
-    src/state.c \
-    src/state.h
 
 glorytun_CFLAGS  += -I$(srcdir)/mud
 glorytun_SOURCES += \

README.md

@@ -1,15 +1,10 @@
-# π₁(Glorytun)=ℤ²
+# π₁(Glorytun)=0
 
 Small, Simple and Stupid VPN over [mud](https://github.com/angt/mud).
 
-#### Work In Progress
-
-This code will probably format your harddisk!
-
 #### Build and Install
 
-Glorytun depends on [libsodium](https://github.com/jedisct1/libsodium) version >= 1.0.4
+Glorytun depends on [libsodium](https://github.com/jedisct1/libsodium) version >= 1.0.4.
-and needs an AES-NI capable CPU.
 
 To build and install the latest version:
 

src/buffer.h

@@ -1,66 +0,0 @@
-#pragma once
-
-#include "common.h"
-
-typedef struct buffer buffer_t;
-
-struct buffer {
-    uint8_t *data;
-    uint8_t *read;
-    uint8_t *write;
-    uint8_t *end;
-};
-
-static inline void buffer_setup (buffer_t *buffer, void *data, size_t size)
-{
-    if (!data)
-        data = malloc(ALIGN(size));
-
-    buffer->data  = data;
-    buffer->read  = data;
-    buffer->write = data;
-    buffer->end   = data;
-    buffer->end  += size;
-}
-
-static inline void buffer_format (buffer_t *buffer)
-{
-    buffer->write = buffer->data;
-    buffer->read  = buffer->data;
-}
-
-_pure_
-static inline size_t buffer_size (buffer_t *buffer)
-{
-    return buffer->end-buffer->data;
-}
-
-_pure_
-static inline size_t buffer_write_size (buffer_t *buffer)
-{
-    return buffer->end-buffer->write;
-}
-
-_pure_
-static inline size_t buffer_read_size (buffer_t *buffer)
-{
-    return buffer->write-buffer->read;
-}
-
-static inline void buffer_shift (buffer_t *buffer)
-{
-    if (buffer->read==buffer->data)
-        return;
-
-    if (buffer->read==buffer->write) {
-        buffer_format(buffer);
-        return;
-    }
-
-    const size_t size = buffer_read_size(buffer);
-
-    memmove(buffer->data, buffer->read, size);
-
-    buffer->read  = buffer->data;
-    buffer->write = buffer->data+size;
-}

src/common.c

@@ -1,9 +1,10 @@
 #include "common.h"
 
-#include <stdio.h>
 #include <stdarg.h>
+#include <stdio.h>
 
-int gt_print (const char *fmt, ...)
+int
+gt_print(const char *fmt, ...)
 {
     va_list ap;
     va_start(ap, fmt);
@@ -16,7 +17,8 @@ int gt_print (const char *fmt, ...)
     return ret;
 }
 
-void gt_log (const char *fmt, ...)
+void
+gt_log(const char *fmt, ...)
 {
     va_list ap;
     va_start(ap, fmt);
@@ -24,7 +26,8 @@ void gt_log (const char *fmt, ...)
     va_end(ap);
 }
 
-void gt_fatal (const char *fmt, ...)
+void
+gt_fatal(const char *fmt, ...)
 {
     va_list ap;
     va_start(ap, fmt);
@@ -34,17 +37,19 @@ void gt_fatal (const char *fmt, ...)
     exit(EXIT_FAILURE);
 }
 
-void gt_na (const char *name)
+void
+gt_na(const char *name)
 {
     gt_log("%s is not available on your platform\n", name);
 }
 
-int gt_tohex (char *dst, size_t dst_size, const uint8_t *src, size_t src_size)
+int
+gt_tohex(char *dst, size_t dst_size, const uint8_t *src, size_t src_size)
 {
-    if _0_(!dst_size)
+    if (_0_(!dst_size))
         return -1;
 
-    if _0_(((dst_size-1)/2)<src_size)
+    if (_0_(((dst_size - 1) / 2) < src_size))
         return -1;
 
     static const char tbl[] = "0123456789ABCDEF";
@@ -59,8 +64,8 @@ int gt_tohex (char *dst, size_t dst_size, const uint8_t *src, size_t src_size)
     return 0;
 }
 
-_const_
+_const_ static inline int
-static inline int fromhex (const char c)
+fromhex(const char c)
 {
     if (c >= '0' && c <= '9')
         return c - '0';
@@ -74,19 +79,20 @@ static inline int fromhex (const char c)
     return -1;
 }
 
-int gt_fromhex (uint8_t *dst, size_t dst_size, const char *src, size_t src_size)
+int
+gt_fromhex(uint8_t *dst, size_t dst_size, const char *src, size_t src_size)
 {
-    if _0_(src_size&1)
+    if (_0_(src_size & 1))
         return -1;
 
-    if _0_(dst_size<(src_size/2))
+    if (_0_(dst_size < (src_size / 2)))
         return -1;
 
     for (size_t i = 0; i < src_size; i += 2) {
         const int a = fromhex(src[i]);
         const int b = fromhex(src[i + 1]);
 
-        if _0_(a==-1 || b==-1)
+        if (_0_(a == -1 || b == -1))
             return -1;
 
         *dst++ = (a << 4) | b;

src/common.h

@@ -29,6 +29,12 @@
 #define _const_        __attribute__ ((const))
 #define _align_(...)   __attribute__ ((aligned(__VA_ARGS__)))
 
+#undef MAX
+#define MAX(x,y) ({ __typeof__(x) X=(x); __typeof__(y) Y=(y); X > Y ? X : Y; })
+
+#undef MIN
+#define MIN(x,y) ({ __typeof__(x) X=(x); __typeof__(y) Y=(y); X < Y ? X : Y; })
+
 int  gt_print (const char *, ...) _printf_(1,2);
 void gt_log   (const char *, ...) _printf_(1,2);
 void gt_fatal (const char *, ...) _printf_(1,2) _noreturn_;

src/db.c

@@ -12,14 +12,14 @@ struct node {
     uint32_t point;
 };
 
-_pure_
+_pure_ static inline size_t
-static inline size_t db_size (const uint8_t *a)
+db_size(const uint8_t *a)
 {
     return (a[0] ?: str_len((char *)a + 1)) + 1;
 }
 
-_pure_
+_pure_ static inline size_t
-static inline size_t db_cmp (const uint8_t *a, const uint8_t *b)
+db_cmp(const uint8_t *a, const uint8_t *b)
 {
     const size_t size = a[0];
 
@@ -39,8 +39,8 @@ static inline size_t db_cmp (const uint8_t *a, const uint8_t *b)
     return 0;
 }
 
-_pure_
+_pure_ static inline int
-static inline int db_dir (const uint32_t point, uint8_t *data, const size_t size)
+db_dir(const uint32_t point, uint8_t *data, const size_t size)
 {
     const size_t pos = point >> 8;
 
@@ -50,9 +50,10 @@ static inline int db_dir (const uint32_t point, uint8_t *data, const size_t size
     return ((point | data[pos]) & 255) == 255;
 }
 
-uint8_t *db_search (uint8_t **p, uint8_t *data)
+uint8_t *
+db_search(uint8_t **p, uint8_t *data)
 {
-    if _0_(!*p)
+    if (_0_(!*p))
         return NULL;
 
     uint8_t *r = *p;
@@ -69,12 +70,13 @@ uint8_t *db_search (uint8_t **p, uint8_t *data)
     return NULL;
 }
 
-uint8_t *db_insert (uint8_t **p, uint8_t *data)
+uint8_t *
+db_insert(uint8_t **p, uint8_t *data)
 {
-    if _0_(CBIT(data))
+    if (_0_(CBIT(data)))
         return NULL;
 
-    if _0_(!*p) {
+    if (_0_(!*p)) {
         *p = data;
         return data;
     }
@@ -89,7 +91,7 @@ uint8_t *db_insert (uint8_t **p, uint8_t *data)
 
     const size_t diff = db_cmp(r, data);
 
-    if _0_(!diff)
+    if (_0_(!diff))
         return r;
 
     const size_t pos = diff - 1;
@@ -107,7 +109,7 @@ uint8_t *db_insert (uint8_t **p, uint8_t *data)
 
     struct node *node = malloc(sizeof(struct node));
 
-    if _0_(!node)
+    if (_0_(!node))
         return NULL;
 
     const int dir = (mask | r[pos]) == 255;
@@ -121,9 +123,10 @@ uint8_t *db_insert (uint8_t **p, uint8_t *data)
     return data;
 }
 
-uint8_t *db_remove (uint8_t **p, uint8_t *data)
+uint8_t *
+db_remove(uint8_t **p, uint8_t *data)
 {
-    if _0_(!*p)
+    if (_0_(!*p))
         return NULL;
 
     const size_t size = db_size(data);
@@ -139,7 +142,7 @@ uint8_t *db_remove (uint8_t **p, uint8_t *data)
         p = node->child + dir;
     }
 
-    if _0_(db_cmp(data, *p))
+    if (_0_(db_cmp(data, *p)))
         return NULL;
 
     uint8_t *r = *p;

src/ip.h

@@ -10,8 +10,8 @@ struct ip_common {
     uint16_t size;
 };
 
-_pure_
+_pure_ static inline uint8_t
-static inline uint8_t ip_get_version (const uint8_t *data, size_t size)
+ip_get_version(const uint8_t *data, size_t size)
 {
     if (size < 20)
         return 0;
@@ -19,7 +19,8 @@ static inline uint8_t ip_get_version (const uint8_t *data, size_t size)
     return data[0] >> 4;
 }
 
-static inline int ip_get_common (struct ip_common *ic, const uint8_t *data, size_t size)
+static inline int
+ip_get_common(struct ip_common *ic, const uint8_t *data, size_t size)
 {
     ic->version = ip_get_version(data, size);
 

src/main.c

@@ -1,19 +1,17 @@
 #include "common.h"
 
-#include "buffer.h"
-#include "ip.h"
-#include "str.h"
-#include "option.h"
-#include "tun.h"
 #include "db.h"
-#include "state.h"
+#include "ip.h"
+#include "option.h"
+#include "str.h"
+#include "tun.h"
 
+#include <fcntl.h>
 #include <inttypes.h>
 #include <limits.h>
-#include <stdio.h>
-#include <signal.h>
 #include <poll.h>
-#include <fcntl.h>
+#include <signal.h>
+#include <stdio.h>
 #include <sys/socket.h>
 #include <sys/time.h>
 
@@ -26,14 +24,41 @@
 #define O_CLOEXEC 0
 #endif
 
+#define GT_MTU(X) ((X) - 28)
+
 static struct {
     volatile sig_atomic_t quit;
-    volatile sig_atomic_t info;
+    char *dev;
-    int timeout;
+    char *keyfile;
-    int state_fd;
+    char *host;
-} gt;
+    long port;
+    struct {
+        char *list;
+        char *backup;
+        long port;
+    } bind;
+    long mtu;
+    long timeout;
+    long time_tolerance;
+    int ipv4;
+    int ipv6;
+    int mtu_auto;
+    int chacha20;
+    int version;
+} gt = {
+    .port = 5000,
+    .bind = {
+        .port = 5000,
+    },
+    .timeout = 5000,
+    .ipv4 = 1,
+#ifdef __linux__
+    .ipv6 = 1,
+#endif
+};
 
-static void fd_set_nonblock (int fd)
+static void
+fd_set_nonblock(int fd)
 {
     int ret;
 
@@ -51,21 +76,14 @@ static void fd_set_nonblock (int fd)
         perror("fcntl O_NONBLOCK");
 }
 
-static void gt_sa_handler (int sig)
+static void
+gt_quit_handler(int sig)
 {
-    switch (sig) {
-    case SIGINT:
-    case SIGQUIT:
-    case SIGTERM:
     gt.quit = 1;
-        break;
-    case SIGUSR1:
-        gt.info = 1;
-        break;
-    }
 }
 
-static void gt_set_signal (void)
+static void
+gt_set_signal(void)
 {
     struct sigaction sa = {
         .sa_flags = 0,
@@ -73,133 +91,36 @@ static void gt_set_signal (void)
 
     sigemptyset(&sa.sa_mask);
 
-    sa.sa_handler = gt_sa_handler;
+    sa.sa_handler = gt_quit_handler;
     sigaction(SIGINT, &sa, NULL);
     sigaction(SIGQUIT, &sa, NULL);
     sigaction(SIGTERM, &sa, NULL);
-    sigaction(SIGUSR1, &sa, NULL);
 
     sa.sa_handler = SIG_IGN;
     sigaction(SIGHUP, &sa, NULL);
     sigaction(SIGPIPE, &sa, NULL);
+    sigaction(SIGUSR1, &sa, NULL);
+    sigaction(SIGUSR2, &sa, NULL);
 }
 
-static ssize_t fd_read (int fd, void *data, size_t size)
+static void
-{
+gt_print_secretkey(struct mud *mud)
-    if ((fd==-1) || !size)
-        return -1;
-
-    ssize_t ret = read(fd, data, size);
-
-    if (ret==-1) {
-        if (errno==EAGAIN || errno==EINTR)
-            return -1;
-
-        if (errno)
-            perror("read");
-
-        return 0;
-    }
-
-    return ret;
-}
-
-static ssize_t fd_write (int fd, const void *data, size_t size)
-{
-    if ((fd==-1) || !size)
-        return -1;
-
-    ssize_t ret = write(fd, data, size);
-
-    if (ret==-1) {
-        if (errno==EAGAIN || errno==EINTR)
-            return -1;
-
-        if (errno==EPIPE || errno==ECONNRESET)
-            return 0;
-
-        if (errno)
-            perror("write");
-
-        return 0;
-    }
-
-    return ret;
-}
-
-static size_t fd_read_all (int fd, void *data, size_t size)
-{
-    size_t done = 0;
-
-    while (done<size) {
-        ssize_t ret = fd_read(fd, (uint8_t *)data+done, size-done);
-
-        if (!ret)
-            break;
-
-        if (ret<0) {
-            struct pollfd pollfd = {
-                .fd = fd,
-                .events = POLLIN,
-            };
-
-            if (!poll(&pollfd, 1, gt.timeout))
-                break;
-
-            continue;
-        }
-
-        done += ret;
-    }
-
-    return done;
-}
-
-static size_t fd_write_all (int fd, const void *data, size_t size)
-{
-    size_t done = 0;
-
-    while (done<size) {
-        ssize_t ret = fd_write(fd, (const uint8_t *)data+done, size-done);
-
-        if (!ret)
-            break;
-
-        if (ret<0) {
-            struct pollfd pollfd = {
-                .fd = fd,
-                .events = POLLOUT,
-            };
-
-            if (!poll(&pollfd, 1, gt.timeout))
-                break;
-
-            continue;
-        }
-
-        done += ret;
-    }
-
-    return done;
-}
-
-static int gt_setup_secretkey (struct mud *mud, char *keyfile)
 {
     unsigned char key[32];
-
-    if (str_empty(keyfile)) {
-        char buf[2*sizeof(key)+1];
     size_t size = sizeof(key);
 
     if (mud_get_key(mud, key, &size))
-            return -1;
+        return;
+
+    char buf[2 * sizeof(key) + 1];
 
     gt_tohex(buf, sizeof(buf), key, size);
-        state_send(gt.state_fd, "SECRETKEY", buf);
+    gt_print("secret key: %s\n", buf);
-
-        return 0;
 }
 
+static int
+gt_setup_secretkey(struct mud *mud, char *keyfile)
+{
     int fd;
 
     do {
@@ -211,12 +132,25 @@ static int gt_setup_secretkey (struct mud *mud, char *keyfile)
         return -1;
     }
 
+    unsigned char key[32];
     char buf[2 * sizeof(key)];
-    size_t r = fd_read_all(fd, buf, sizeof(buf));
+    size_t size = 0;
+
+    while (size < sizeof(buf)) {
+        ssize_t r = read(fd, &buf[size], sizeof(buf) - size);
+
+        if (r <= (ssize_t)0) {
+            if (r && (errno == EAGAIN || errno == EINTR))
+                continue;
+            break;
+        }
+
+        size += r;
+    }
 
     close(fd);
 
-    if (r!=sizeof(buf)) {
+    if (size != sizeof(buf)) {
         gt_log("unable to read secret key\n");
         return -1;
     }
@@ -231,45 +165,23 @@ static int gt_setup_secretkey (struct mud *mud, char *keyfile)
     return 0;
 }
 
-int main (int argc, char **argv)
+static int
+gt_setup_option(int argc, char **argv)
 {
-    gt_set_signal();
+    // clang-format off
-
-    char *host = NULL;
-    long port = 5000;
-
-    char *bind_list = NULL;
-    long bind_port = 5000;
-
-    char *dev = NULL;
-    char *keyfile = NULL;
-    char *statefile = NULL;
-
-    long mtu = 1450;
-
-    gt.timeout = 5000;
-
-    long time_tolerance = 0;
-
-    int v4 = 1;
-    int v6 = 0;
-
-#ifdef __linux__
-    v6 = 1;
-#endif
 
     struct option opts[] = {
-        { "host",           &host,           option_str    },
+        { "host",           &gt.host,           option_str    },
-        { "port",           &port,           option_long   },
+        { "port",           &gt.port,           option_long   },
-        { "bind",           &bind_list,      option_str    },
+        { "bind",           &gt.bind.list,      option_str    },
-        { "bind-port",      &bind_port,      option_long   },
+        { "bind-backup",    &gt.bind.backup,    option_str    },
-        { "dev",            &dev,            option_str    },
+        { "bind-port",      &gt.bind.port,      option_long   },
-        { "mtu",            &mtu,            option_long   },
+        { "dev",            &gt.dev,            option_str    },
-        { "keyfile",        &keyfile,        option_str    },
+        { "mtu",            &gt.mtu,            option_long   },
-        { "multiqueue",     NULL,            option_option },
+        { "mtu-auto",       NULL,               option_option },
-        { "statefile",      &statefile,      option_str    },
+        { "keyfile",        &gt.keyfile,        option_str    },
         { "timeout",        &gt.timeout,        option_long   },
-        { "time-tolerance", &time_tolerance, option_long   },
+        { "time-tolerance", &gt.time_tolerance, option_long   },
         { "v4only",         NULL,               option_option },
         { "v6only",         NULL,               option_option },
         { "chacha20",       NULL,               option_option },
@@ -277,249 +189,258 @@ int main (int argc, char **argv)
         {  NULL                                               },
     };
 
+    // clang-format on
+
     if (option(opts, argc, argv))
         return 1;
 
-    if (option_is_set(opts, "version")) {
+    int v4only = option_is_set(opts, "v4only");
-        gt_print(PACKAGE_STRING"\n");
+    int v6only = option_is_set(opts, "v6only");
-        return 0;
-    }
 
-    if (option_is_set(opts, "v4only")) {
+    if (v4only && v6only) {
-        v4 = 1;
+        gt_log("v4only and v6only cannot be both set\n");
-        v6 = 0;
-    }
-
-    if (option_is_set(opts, "v6only")) {
-        v4 = 0;
-        v6 = 1;
-    }
-
-    if (option_is_set(opts, "v4only") &&
-        option_is_set(opts, "v6only")) {
-        gt_log("v4only and v6only are both set\n");
         return 1;
     }
 
-    if (host && !option_is_set(opts, "keyfile")) {
+    if (gt.host && !option_is_set(opts, "keyfile")) {
         gt_log("keyfile option must be set\n");
         return 1;
     }
 
-    if (gt.timeout<=0 || gt.timeout>INT_MAX) {
+    if ((int)gt.timeout <= 0) {
         gt_log("bad timeout\n");
         return 1;
     }
 
-    gt.state_fd = state_create(statefile);
+    if (v4only) {
+        gt.ipv4 = 1;
+        gt.ipv6 = 0;
+    }
 
-    if (statefile && gt.state_fd==-1)
+    if (v6only) {
+        gt.ipv4 = 0;
+        gt.ipv6 = 1;
+    }
+
+    gt.mtu_auto = option_is_set(opts, "mtu-auto");
+    gt.chacha20 = option_is_set(opts, "chacha20");
+    gt.version = option_is_set(opts, "version");
+
+    return 0;
+}
+
+static void
+gt_setup_mtu(struct mud *mud, char *tun_name)
+{
+    int mtu = mud_get_mtu(mud);
+
+    if (mtu == (int)gt.mtu)
+        return;
+
+    gt.mtu = mtu;
+
+    gt_log("setup MTU to %i on interface %s\n", mtu, tun_name);
+
+    if (tun_set_mtu(tun_name, mtu) == -1)
+        perror("tun_set_mtu");
+}
+
+int
+main(int argc, char **argv)
+{
+    gt_set_signal();
+
+    if (gt_setup_option(argc, argv))
         return 1;
 
+    if (gt.version) {
+        gt_print(PACKAGE_STRING "\n");
+        return 0;
+    }
+
+    int icmp_fd = -1;
+
+    if (gt.ipv4 && gt.mtu_auto) {
+        icmp_fd = socket(AF_INET, SOCK_RAW, IPPROTO_ICMP);
+
+        if (icmp_fd == -1)
+            gt_log("couldn't create ICMP socket\n");
+    }
+
     char *tun_name = NULL;
 
-    int tun_fd = tun_create(dev, &tun_name, option_is_set(opts, "multiqueue"));
+    int tun_fd = tun_create(gt.dev, &tun_name);
 
     if (tun_fd == -1) {
         gt_log("couldn't create tun device\n");
         return 1;
     }
 
-    if (tun_set_mtu(tun_name, mtu)==-1) {
+    struct mud *mud = mud_create(gt.bind.port, gt.ipv4, gt.ipv6,
-        perror("tun_set_mtu");
+                                 !gt.chacha20, GT_MTU(gt.mtu));
-        return 1;
-    }
-
-    fd_set_nonblock(tun_fd);
-
-    int chacha = option_is_set(opts, "chacha20");
-
-    struct mud *mud = mud_create(bind_port, v4, v6, !chacha, mtu);
 
     if (!mud) {
         gt_log("couldn't create mud\n");
         return 1;
     }
 
-    if (gt_setup_secretkey(mud, keyfile))
+    if (str_empty(gt.keyfile)) {
+        gt_print_secretkey(mud);
+    } else {
+        if (gt_setup_secretkey(mud, gt.keyfile))
             return 1;
+    }
 
     mud_set_send_timeout_msec(mud, gt.timeout);
 
-    if (time_tolerance > 0)
+    if (gt.time_tolerance > 0)
-        mud_set_time_tolerance_sec(mud, time_tolerance);
+        mud_set_time_tolerance_sec(mud, gt.time_tolerance);
 
-    if (host && port && bind_list) {
+    if (gt.host && gt.port) {
+        if (gt.bind.backup) {
+            if (mud_peer(mud, gt.bind.backup, gt.host, gt.port, 1)) {
+                perror("mud_peer (backup)");
+                return 1;
+            }
+        }
+
+        if (gt.bind.list) {
             char tmp[1024];
             char *name = &tmp[0];
 
-        size_t size = str_cpy(tmp, bind_list, sizeof(tmp)-1);
+            str_cpy(tmp, gt.bind.list, sizeof(tmp) - 1);
 
-        for (size_t i=0; i<size; i++) {
+            while (*name) {
-            if (tmp[i]!=',')
+                char *p = name;
-                continue;
 
-            tmp[i] = 0;
+                while (*p && *p != ',')
+                    p++;
 
-            if (mud_peer(mud, name, host, port))
+                if (*p)
-                return 1;
+                    *p++ = 0;
 
-            name = &tmp[i+1];
+                if (mud_peer(mud, name, gt.host, gt.port, 0)) {
-        }
+                    perror("mud_peer");
-
-        if (name[0] && mud_peer(mud, name, host, port))
                     return 1;
                 }
 
+                name = p;
+            }
+        }
+    }
+
+    gt_setup_mtu(mud, tun_name);
+
     int mud_fd = mud_get_fd(mud);
 
-    state_send(gt.state_fd, "INITIALIZED", tun_name);
+    fd_set_nonblock(tun_fd);
+    fd_set_nonblock(mud_fd);
+
+    if (icmp_fd != -1)
+        fd_set_nonblock(icmp_fd);
+
+    gt_log("running...\n");
 
     fd_set rfds;
     FD_ZERO(&rfds);
 
-    int started = 0;
+    unsigned char buf[8 * 1024];
 
-    struct {
+    int last_fd = 1 + MAX(tun_fd, MAX(mud_fd, icmp_fd));
-        unsigned char *buf;
-    } send, recv;
-
-    send.buf = malloc(2*mtu);
-    recv.buf = malloc(mtu);
-
-    size_t send_size = 0;
-    size_t send_limit = 0;
-    int send_tc = 0;
-    int send_next_tc = 0;
 
     while (!gt.quit) {
         FD_SET(tun_fd, &rfds);
-
-        if (mud_can_pull(mud)) {
         FD_SET(mud_fd, &rfds);
-        } else {
-            FD_CLR(mud_fd, &rfds);
-        }
 
-        struct timeval timeout = {
+        if (icmp_fd != -1)
-            .tv_usec = 100000,
+            FD_SET(icmp_fd, &rfds);
-        };
 
-        if (mud_can_push(mud) || send_size)
+        if (select(last_fd, &rfds, NULL, NULL, NULL) == -1) {
-            timeout.tv_usec = 1000;
+            if (errno != EBADF)
-
-        if _0_(select(mud_fd+1, &rfds, NULL, NULL, &timeout)==-1) {
-            if (errno==EINTR)
                 continue;
             perror("select");
             return 1;
         }
 
-        if (mud_is_up(mud)) {
+        if (icmp_fd != -1 && FD_ISSET(icmp_fd, &rfds)) {
-            if (!started) {
+            struct sockaddr_storage ss;
-                state_send(gt.state_fd, "STARTED", tun_name);
+            socklen_t sl = sizeof(ss);
-                started = 1;
+            ssize_t r = recvfrom(icmp_fd, buf, sizeof(buf), 0,
+                                 (struct sockaddr *)&ss, &sl);
+            if (r >= 8) {
+                struct ip_common ic;
+                if (!ip_get_common(&ic, buf, r) && ic.proto == 1) {
+                    unsigned char *data = &buf[ic.hdr_size];
+                    if (data[0] == 3) {
+                        int mtu = (data[6] << 8) | data[7];
+                        if (mtu) {
+                            gt_log("received MTU from ICMP: %i\n", mtu);
+                            mud_set_mtu(mud, GT_MTU(mtu));
+                        }
+                    }
                 }
-        } else {
-            if (started) {
-                state_send(gt.state_fd, "STOPPED", tun_name);
-                started = 0;
             }
         }
 
         if (FD_ISSET(tun_fd, &rfds)) {
-            while (send_size<mtu) {
+            size_t size = 0;
-                const ssize_t r = tun_read(tun_fd, send.buf+send_size, mtu);
 
-                if (r<=0) {
+            while (sizeof(buf) - size >= gt.mtu) {
-                    gt.quit |= !r;
+                const int r = tun_read(tun_fd, &buf[size],
+                                       sizeof(buf) - size);
+
+                if (r <= 0 || r > gt.mtu)
                     break;
-                }
 
                 struct ip_common ic;
 
-                if (ip_get_common(&ic, send.buf+send_size, mtu) || ic.size!=r) {
+                if (ip_get_common(&ic, &buf[size], r) || ic.size != r)
-                    gt_log("packet dropped: malformed\n");
-                    continue;
-                }
-
-                send_size += r;
-
-                if (send_size<=mtu) {
-                    send_limit = send_size;
-                    if ((ic.tc&0xFC)>(send_tc&0xFC))
-                        send_tc = ic.tc;
-                } else {
-                    if ((ic.tc&0xFC)>(send_next_tc&0xFC))
-                        send_next_tc = ic.tc;
-                }
-            }
-        }
-
-        if (send_limit) {
-            int r = mud_send(mud, send.buf, send_limit, send_tc);
-
-            if (r==send_limit) {
-                if (send_size>send_limit)
-                    memmove(send.buf, &send.buf[send_limit], send_size-send_limit);
-                send_size -= send_limit;
-                send_limit = send_size;
-                send_tc = send_next_tc;
-                send_next_tc = 0;
-            } else if (r==-1) {
-                if (errno==EMSGSIZE) {
-                    long new_mtu = mud_get_mtu(mud);
-                    if (new_mtu!=mtu) {
-                        size_t total = send_size;
-
-                        if (tun_set_mtu(tun_name, new_mtu)==-1) {
-                            perror("tun_set_mtu");
-                            gt.quit |= 1;
                     break;
+
+                size += r;
             }
 
-                        gt_log("MTU changed: %li\n", new_mtu);
+            int p = 0;
 
-                        mtu = new_mtu;
+            while (p < size) {
-                        send_size = 0;
+                int tc = 0;
-                        send_limit = 0;
+                int q = p;
-                        send_tc = 0;
-                        send_next_tc = 0;
 
-                        while (send_size<total) {
+                while (q < size) {
                     struct ip_common ic;
 
-                            if (ip_get_common(&ic, send.buf+send_size, mtu))
+                    if ((ip_get_common(&ic, &buf[q], size - q)) ||
+                        (ic.size > size - q))
                         break;
 
-                            send_size += ic.size;
+                    if (q + ic.size > p + gt.mtu)
+                        break;
 
-                            if (send_size<=mtu) {
+                    q += ic.size;
-                                send_limit = send_size;
+
-                                if ((ic.tc&0xFC)>(send_tc&0xFC))
+                    if (tc < (ic.tc & 0xFC))
-                                    send_tc = ic.tc;
+                        tc = ic.tc & 0xFC;
+                }
+
+                if (p == q)
+                    break;
+
+                int r = mud_send(mud, &buf[p], q - p, tc);
+
+                if (r == -1 && errno == EMSGSIZE) {
+                    gt_setup_mtu(mud, tun_name);
                 } else {
-                                if ((ic.tc&0xFC)>(send_next_tc&0xFC))
+                    if (r == -1 && errno != EAGAIN)
-                                    send_next_tc = ic.tc;
-                            }
-                        }
-                    }
-                } else if (errno!=EAGAIN) {
                         perror("mud_send");
                 }
-            }
-        }
 
-        if (mud_push(mud)==-1 && errno!=EAGAIN)
+                p = q;
-            perror("mud_push");
+            }
+        }
 
         if (FD_ISSET(mud_fd, &rfds)) {
-            if (mud_pull(mud)==-1 && errno!=EAGAIN)
+            while (1) {
-                perror("mud_pull");
+                const int size = mud_recv(mud, buf, sizeof(buf));
-        }
-
-        while (!gt.quit) {
-            const int size = mud_recv(mud, recv.buf, mtu);
 
                 if (size <= 0) {
                     if (size == -1 && errno != EAGAIN)
@@ -532,20 +453,17 @@ int main (int argc, char **argv)
                 while (p < size) {
                     struct ip_common ic;
 
-                if (ip_get_common(&ic, recv.buf+p, size-p) || ic.size>size-p)
+                    if ((ip_get_common(&ic, &buf[p], size - p)) ||
+                        (ic.size > size - p))
                         break;
 
-                const ssize_t r = tun_write(tun_fd, recv.buf+p, ic.size);
+                    tun_write(tun_fd, &buf[p], ic.size);
-
-                if (r<=0) {
-                    gt.quit |= !r;
-                    break;
-                }
 
                     p += ic.size;
                 }
             }
         }
+    }
 
     return 0;
 }

src/option.c

@@ -3,7 +3,8 @@
 #include "option.h"
 #include "str.h"
 
-int option_str (void *data, int argc, char **argv)
+int
+option_str(void *data, int argc, char **argv)
 {
     if (argc < 2 || str_empty(argv[1])) {
         gt_print("option `%s' need a string argument\n", argv[0]);
@@ -15,7 +16,8 @@ int option_str (void *data, int argc, char **argv)
     return 1;
 }
 
-int option_long (void *data, int argc, char **argv)
+int
+option_long(void *data, int argc, char **argv)
 {
     if (argc < 2 || str_empty(argv[1])) {
         gt_print("option `%s' need an integer argument\n", argv[0]);
@@ -36,7 +38,8 @@ int option_long (void *data, int argc, char **argv)
     return 1;
 }
 
-int option_is_set (struct option *opts, const char *name)
+int
+option_is_set(struct option *opts, const char *name)
 {
     for (int k = 0; opts[k].name; k++) {
         if (!str_cmp(opts[k].name, name))
@@ -46,7 +49,8 @@ int option_is_set (struct option *opts, const char *name)
     return 0;
 }
 
-int option_option (void *data, int argc, char **argv)
+int
+option_option(void *data, int argc, char **argv)
 {
     if (!data)
         return 0;
@@ -87,7 +91,8 @@ int option_option (void *data, int argc, char **argv)
     return argc;
 }
 
-static int option_usage (struct option *opts, int slen)
+static int
+option_usage(struct option *opts, int slen)
 {
     if (!opts)
         return 0;
@@ -114,7 +119,8 @@ static int option_usage (struct option *opts, int slen)
     return len;
 }
 
-int option (struct option *opts, int argc, char **argv)
+int
+option(struct option *opts, int argc, char **argv)
 {
     int ret = option_option(opts, argc, argv);
 

src/state.c

@@ -1,62 +0,0 @@
-#include "common.h"
-
-#include "state.h"
-#include "str.h"
-
-#include <stdio.h>
-#include <fcntl.h>
-#include <sys/stat.h>
-
-int state_create (const char *filename)
-{
-    if (str_empty(filename))
-        return -1;
-
-    int fd = open(filename, O_WRONLY);
-
-    if (fd==-1) {
-        if (errno!=EINTR)
-            perror("open");
-        return -1;
-    }
-
-    struct stat st = {0};
-
-    if (fstat(fd, &st)==-1) {
-        perror("fstat");
-        close(fd);
-        return -1;
-    }
-
-    if (!S_ISFIFO(st.st_mode)) {
-        gt_log("`%s' is not a fifo\n", filename);
-        close(fd);
-        return -1;
-    }
-
-    return fd;
-}
-
-void state_send (int fd, const char *state, const char *info)
-{
-    if (str_empty(state))
-        return;
-
-    if (fd==-1) {
-        gt_print("%s %s\n", state, info);
-        return;
-    }
-
-    const char *strs[] = { state, " ", info, "\n" };
-    char *str = str_cat(strs, COUNT(strs));
-
-    if (!str) {
-        perror("str_cat");
-        return;
-    }
-
-    if (write(fd, str, str_len(str))==-1 && errno!=EINTR)
-        perror("write");
-
-    free(str);
-}

src/state.h

@@ -1,4 +0,0 @@
-#pragma once
-
-int  state_create (const char *);
-void state_send   (int, const char *, const char *);

src/str.h

@@ -2,7 +2,8 @@
 
 #include "common.h"
 
-static inline size_t str_cpy (char *restrict dst, const char *restrict src, size_t len)
+static inline size_t
+str_cpy(char *restrict dst, const char *restrict src, size_t len)
 {
     if (!dst || !src)
         return 0;
@@ -17,14 +18,14 @@ static inline size_t str_cpy (char *restrict dst, const char *restrict src, size
     return i;
 }
 
-_pure_
+_pure_ static inline int
-static inline int str_empty (const char *restrict str)
+str_empty(const char *restrict str)
 {
     return !str || !str[0];
 }
 
-_pure_
+_pure_ static inline size_t
-static inline size_t str_cmp (const char *restrict sa, const char *restrict sb)
+str_cmp(const char *restrict sa, const char *restrict sb)
 {
     if (!sa || !sb)
         return 1;
@@ -38,8 +39,8 @@ static inline size_t str_cmp (const char *restrict sa, const char *restrict sb)
     return i + 1;
 }
 
-_pure_
+_pure_ static inline size_t
-static inline size_t str_len (const char *restrict str)
+str_len(const char *restrict str)
 {
     if (!str)
         return 0;
@@ -47,7 +48,8 @@ static inline size_t str_len (const char *restrict str)
     return strlen(str);
 }
 
-static inline char *str_cat (const char **strs, size_t count)
+static inline char *
+str_cat(const char **strs, size_t count)
 {
     size_t size = 1;
 

src/tun.c

@@ -1,25 +1,28 @@
 #include "common.h"
 
-#include "tun.h"
-#include "str.h"
 #include "ip.h"
+#include "str.h"
+#include "tun.h"
 
-#include <stdio.h>
 #include <fcntl.h>
+#include <stdio.h>
 
 #include <sys/ioctl.h>
 #include <sys/socket.h>
 #include <sys/uio.h>
 
+#include <net/if.h>
+
 #ifdef __linux__
-#include <linux/if.h>
+#define IFF_TUN 0x0001
-#include <linux/if_tun.h>
+#define IFF_NO_PI 0x1000
+#define TUNSETIFF _IOW('T', 202, int)
 #endif
 
 #ifdef __APPLE__
-#include <sys/sys_domain.h>
-#include <sys/kern_control.h>
 #include <net/if_utun.h>
+#include <sys/kern_control.h>
+#include <sys/sys_domain.h>
 #endif
 
 #if defined(__APPLE__) || defined(__OpenBSD__)
@@ -28,7 +31,8 @@
 
 #ifdef __APPLE__
 
-static int tun_create_by_id (char *name, size_t size, unsigned id, _unused_ int mq)
+static int
+tun_create_by_id(char *name, size_t size, unsigned id)
 {
     int fd = socket(PF_SYSTEM, SOCK_DGRAM, SYSPROTO_CONTROL);
 
@@ -41,7 +45,9 @@ static int tun_create_by_id (char *name, size_t size, unsigned id, _unused_ int
     str_cpy(ci.ctl_name, UTUN_CONTROL_NAME, sizeof(ci.ctl_name) - 1);
 
     if (ioctl(fd, CTLIOCGINFO, &ci)) {
+        int err = errno;
         close(fd);
+        errno = err;
         return -1;
     }
 
@@ -54,7 +60,9 @@ static int tun_create_by_id (char *name, size_t size, unsigned id, _unused_ int
     };
 
     if (connect(fd, (struct sockaddr *)&sc, sizeof(sc))) {
+        int err = errno;
         close(fd);
+        errno = err;
         return -1;
     }
 
@@ -63,21 +71,25 @@ static int tun_create_by_id (char *name, size_t size, unsigned id, _unused_ int
     return fd;
 }
 
-static int tun_create_by_name (char *name, size_t size, char *dev_name, int mq)
+static int
+tun_create_by_name(char *name, size_t size, char *dev_name)
 {
     unsigned id = 0;
 
-    if (sscanf(dev_name, "utun%u", &id)!=1)
+    if (sscanf(dev_name, "utun%u", &id) != 1) {
+        errno = EINVAL;
         return -1;
+    }
 
-    return tun_create_by_id(name, size, id, mq);
+    return tun_create_by_id(name, size, id);
 }
 
 #else /* not __APPLE__ */
 
 #ifdef __linux__
 
-static int tun_create_by_name (char *name, size_t size, char *dev_name, int mq)
+static int
+tun_create_by_name(char *name, size_t size, char *dev_name)
 {
     int fd = open("/dev/net/tun", O_RDWR);
 
@@ -88,12 +100,6 @@ static int tun_create_by_name (char *name, size_t size, char *dev_name, int mq)
         .ifr_flags = IFF_TUN | IFF_NO_PI,
     };
 
-    if (mq) {
-#ifdef IFF_MULTI_QUEUE
-        ifr.ifr_flags |= IFF_MULTI_QUEUE;
-#endif
-    }
-
     str_cpy(ifr.ifr_name, dev_name, IFNAMSIZ - 1);
 
     if (ioctl(fd, TUNSETIFF, &ifr)) {
@@ -108,7 +114,8 @@ static int tun_create_by_name (char *name, size_t size, char *dev_name, int mq)
 
 #else /* not __linux__ not __APPLE__ */
 
-static int tun_create_by_name (char *name, size_t size, char *dev_name, _unused_ int mq)
+static int
+tun_create_by_name(char *name, size_t size, char *dev_name)
 {
     char path[64];
 
@@ -120,32 +127,29 @@ static int tun_create_by_name (char *name, size_t size, char *dev_name, _unused_
 
 #endif /* not __APPLE__ */
 
-static int tun_create_by_id (char *name, size_t size, unsigned id, int mq)
+static int
+tun_create_by_id(char *name, size_t size, unsigned id)
 {
     char dev_name[64];
 
     snprintf(dev_name, sizeof(dev_name), "tun%u", id);
 
-    return tun_create_by_name(name, size, dev_name, mq);
+    return tun_create_by_name(name, size, dev_name);
 }
 
 #endif
 
-int tun_create (char *dev_name, char **ret_name, int mq)
+int
+tun_create(char *dev_name, char **ret_name)
 {
     char name[64] = {0};
     int fd = -1;
 
-#ifndef IFF_MULTI_QUEUE
-    if (mq)
-        gt_na("IFF_MULTI_QUEUE");
-#endif
-
     if (str_empty(dev_name)) {
         for (unsigned id = 0; id < 32 && fd == -1; id++)
-            fd = tun_create_by_id(name, sizeof(name), id, mq);
+            fd = tun_create_by_id(name, sizeof(name), id);
     } else {
-        fd = tun_create_by_name(name, sizeof(name), dev_name, mq);
+        fd = tun_create_by_name(name, sizeof(name), dev_name);
     }
 
     if (fd != -1 && ret_name)
@@ -154,48 +158,45 @@ int tun_create (char *dev_name, char **ret_name, int mq)
     return fd;
 }
 
-ssize_t tun_read (int fd, void *data, size_t size)
+int
+tun_read(int fd, void *data, size_t size)
 {
     if (!size)
-        return -1;
+        return 0;
 
 #ifdef GT_BSD_TUN
     uint32_t family;
 
     struct iovec iov[2] = {
-        { .iov_base = &family, .iov_len = sizeof(family) },
+        {
-        { .iov_base = data, .iov_len = size }
+            .iov_base = &family,
+            .iov_len = sizeof(family),
+        },
+        {
+            .iov_base = data,
+            .iov_len = size,
+        },
     };
 
     ssize_t ret = readv(fd, iov, 2);
-#else
-    ssize_t ret = read(fd, data, size);
-#endif
 
-    if (ret==-1) {
+    if (ret <= (ssize_t)0)
-        if (errno==EAGAIN || errno==EINTR)
+        return ret;
-            return -1;
 
-        if (errno)
+    if (ret <= (ssize_t)sizeof(family))
-            perror("tun read");
-
-        return 0;
-    }
-
-#ifdef GT_BSD_TUN
-    if (ret<(ssize_t) sizeof(family))
         return 0;
 
     return ret - sizeof(family);
 #else
-    return ret;
+    return read(fd, data, size);
 #endif
 }
 
-ssize_t tun_write (int fd, const void *data, size_t size)
+int
+tun_write(int fd, const void *data, size_t size)
 {
     if (!size)
-        return -1;
+        return 0;
 
 #ifdef GT_BSD_TUN
     uint32_t family;
@@ -208,40 +209,37 @@ ssize_t tun_write (int fd, const void *data, size_t size)
         family = htonl(AF_INET6);
         break;
     default:
+        errno = EINVAL;
         return -1;
     }
 
     struct iovec iov[2] = {
-        { .iov_base = &family, .iov_len = sizeof(family) },
+        {
-        { .iov_base = (void *) data, .iov_len = size },
+            .iov_base = &family,
+            .iov_len = sizeof(family),
+        },
+        {
+            .iov_base = (void *)data,
+            .iov_len = size,
+        },
     };
 
     ssize_t ret = writev(fd, iov, 2);
-#else
-    ssize_t ret = write(fd, data, size);
-#endif
 
-    if (ret==-1) {
+    if (ret <= (ssize_t)0)
-        if (errno==EAGAIN || errno==EINTR)
+        return ret;
-            return -1;
 
-        if (errno)
+    if (ret <= (ssize_t)sizeof(family))
-            perror("tun write");
-
-        return 0;
-    }
-
-#ifdef GT_BSD_TUN
-    if (ret<(ssize_t) sizeof(family))
         return 0;
 
     return ret - sizeof(family);
 #else
-    return ret;
+    return write(fd, data, size);
 #endif
 }
 
-int tun_set_mtu (char *dev_name, int mtu)
+int
+tun_set_mtu(char *dev_name, int mtu)
 {
     struct ifreq ifr = {
         .ifr_mtu = mtu,

src/tun.h

@@ -1,8 +1,6 @@
 #pragma once
 
-#include <unistd.h>
+int tun_create  (char *, char **);
-
+int tun_read    (int, void *, size_t);
-int     tun_create  (char *, char **, int);
+int tun_write   (int, const void *, size_t);
-ssize_t tun_read    (int, void *, size_t);
-ssize_t tun_write   (int, const void *, size_t);
 int tun_set_mtu (char *, int);