miegl/b210-k7-fpga
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Get rid of unnecessary bash wrappers in subprocesses.Popen

Browse Source 
Signed-off-by: Frederik Pfautsch <frederik.pfautsch@missinglinkelectronics.com>


Original-commit: e572bab3ee5aa40f57bdc6e11d6381cad1d1401a
This commit is contained in:
Frederik Pfautsch
2025-02-03 21:51:38 +01:00
committed by Jörg Hofrichter
parent f4b6def040
commit 8aefaa7582
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/utils/repeat_fpga_build.py
+3 -1
View File
@@ -374,9 +374,11 @@ def run_fpga_build(
cmd_build_num, cmd_build_num,
) )
logging.info(f"Running FPGA build command: {cmd}") logging.info(f"Running FPGA build command: {cmd}")
my_env = os.environ.copy()
with subprocess.Popen( with subprocess.Popen(
cmd, cmd,
shell=True, shell=True,
env=my_env,
stdout=subprocess.PIPE, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT, stderr=subprocess.STDOUT,
bufsize=1, bufsize=1,
@@ -460,7 +462,7 @@ def run_ip_build(
logging.info(f"Running IP build with command: {cmd}") logging.info(f"Running IP build with command: {cmd}")
output = "" output = ""
with subprocess.Popen( with subprocess.Popen(
f'/bin/bash -c "{cmd}"', cmd,
shell=True, shell=True,
stdout=subprocess.PIPE, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT, stderr=subprocess.STDOUT,